rainerschamm commented on PR #14797:
URL: https://github.com/apache/iceberg/pull/14797#issuecomment-4874246981
> Hi everyone iceberg.tables.cdc-field / iceberg.tables.upsert-mode-enabled
— still valid in v.1.10.2? I checked IcebergSinkConfig.java on the
apache-iceberg-1.10.2 tag and neither iceberg.tables.cdc-field nor
iceberg.tables.upsert-mode-enabled appear in newConfigDef(). Only
iceberg.tables.default-id-columns / iceberg.table.
> .id-columns exist.
> But several examples (including configs referenced in #15351) use both
properties as if they were valid for
org.apache.iceberg.connect.IcebergSinkConnector. I suspect these are leftovers
from the old Tabular fork's ConfigDef and were never ported to the ASF
connector.
> Can someone confirm: is native upsert mode supported at all in the current
sink (any property name), or is MERGE INTO downstream still the recommended
approach? Unrecognized properties seem to fail silently, which made this
confusing to debug.
No, they are not.
They would have been introduced by this PR, but that's not likely to happen
at this stage:
```
+ private static final String TABLES_CDC_FIELD_PROP =
"iceberg.tables.cdc-field";
+ private static final String TABLES_UPSERT_MODE_ENABLED_PROP =
+ "iceberg.tables.upsert-mode-enabled";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
