nastra commented on code in PR #17022:
URL: https://github.com/apache/iceberg/pull/17022#discussion_r3518264453
##########
data/src/test/java/org/apache/iceberg/io/TestWriterMetrics.java:
##########
@@ -353,21 +353,11 @@ public void testMaxColumnsWithDefaultOverride() throws
IOException {
}
protected void checkRowStatistics(Map<Integer, ByteBuffer> bounds) {
- assertThat(bounds).hasSize(4);
- assertThat((int) Conversions.fromByteBuffer(Types.IntegerType.get(),
bounds.get(1)))
- .isEqualTo(3);
+ assertThat(bounds).hasSize(2);
Review Comment:
also maybe we can just inline this check into the test that uses it and
remove `checkRowStatistics()`, since it's really only used in a single test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
