dramaticlly commented on code in PR #17022:
URL: https://github.com/apache/iceberg/pull/17022#discussion_r3507765749
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkFileWriterFactory.java:
##########
@@ -166,10 +166,7 @@ public PositionDeleteWriter<InternalRow>
newPositionDeleteWriter(
} else {
LOG.warn("Position deletes with deleted rows are deprecated and will be
removed in 1.12.0.");
Map<String, String> properties = table == null ? ImmutableMap.of() :
table.properties();
- MetricsConfig metricsConfig =
- table == null
- ? MetricsConfig.forPositionDelete()
- : MetricsConfig.forPositionDelete(table);
+ MetricsConfig metricsConfig = MetricsConfig.forPositionDelete();
Review Comment:
Agreed, I have a separate PR aimed to remove deprecated method for 1.12
which include the `MetricsConfig.forPositionDelete(table)` in
https://github.com/apache/iceberg/pull/16449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
