rdblue commented on PR #16964: URL: https://github.com/apache/iceberg/pull/16964#issuecomment-4848985667
I brought this up in the Slack channel, but I think we need to stop adding builders and stop using the builders that are already present. Right now, we don't have any real uses of theses classes and we don't know how we need the builder to work. For instance, are we going to build tracked files directly? Or are we going to wrap `DataFile` and write the wrapped version? Introducing builders too early means we end up with builders that can create objects but aren't actually doing a good job validating those objects (see the follow ups on the `Tracking` builder). I think we've again discovered that tests are not a good reason to introduce code into main, and I think most of the motivation for adding builders was to use them in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
