stevenzwu commented on code in PR #16964:
URL: https://github.com/apache/iceberg/pull/16964#discussion_r3482697386
##########
core/src/main/java/org/apache/iceberg/TrackedFileBuilder.java:
##########
@@ -111,17 +105,15 @@ static TrackedFile deleted(TrackedFile source, long
newSnapshotId) {
/**
* Returns a REPLACED tracked file derived from {@code source}.
*
- * <p>Manifest entries cannot transition to REPLACED.
+ * <p>Manifest files cannot transition to REPLACED.
*
* @param source source tracked file
* @param newSnapshotId the snapshot ID in which the new tracked file will
be committed
*/
static TrackedFile replaced(TrackedFile source, long newSnapshotId) {
Preconditions.checkArgument(source != null, "Invalid source: null");
Preconditions.checkArgument(
- !isLeafManifest(source.contentType()),
- "Manifest entries cannot transition to REPLACED, but entry type is:
%s",
- source.contentType());
+ !isLeafManifest(source.contentType()), "Cannot transition manifest
files to REPLACED");
Review Comment:
```suggestion
!isLeafManifest(source.contentType()), "Cannot transition manifest
entries to REPLACED status");
```
##########
core/src/main/java/org/apache/iceberg/TrackedFileBuilder.java:
##########
@@ -238,21 +229,28 @@ TrackedFileBuilder deletionVector(DeletionVector
newDeletionVector) {
Preconditions.checkArgument(newDeletionVector != null, "Invalid deletion
vector: null");
Preconditions.checkArgument(
contentType == FileContent.DATA,
- "Deletion vector can only be added to DATA entries, but entry type is:
%s",
+ "Cannot add deletion vector for file with content: %s",
contentType);
Preconditions.checkArgument(
- this.deletionVector == null ||
!this.deletionVector.equals(newDeletionVector),
- "The same deletion vector already added");
+ deletionVector == null || deletionVector.cardinality() <
newDeletionVector.cardinality(),
Review Comment:
+1 to keep the stricter validation for now and relax in the future if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
