raunaqmorarka commented on code in PR #17017:
URL: https://github.com/apache/iceberg/pull/17017#discussion_r3497645681
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -443,6 +454,37 @@ public void testSupportedReadsForParquetV2() throws
Exception {
assertRecordsMatch(schema, 30000, data, dataFile, false, BATCH_SIZE);
}
+ @Test
+ public void testAllNullStringAndBinaryColumnsParquetV2() throws Exception {
+ // An all-null string/binary column decodes to a DELTA_LENGTH_BYTE_ARRAY
length stream with
Review Comment:
Good catch, fixed. V2 string/binary uses DELTA_BYTE_ARRAY (the all-null page
hits the prefix-length read in VectorizedDeltaByteArrayValuesReader). Updated
the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
