drexler-sky commented on code in PR #16993:
URL: https://github.com/apache/iceberg/pull/16993#discussion_r3489150222
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3093,6 +3093,7 @@ components:
allOf:
- $ref: '#/components/schemas/BaseUpdate'
required:
+ - action
Review Comment:
Yes, exactly. `action` was always required via `BaseUpdate`, so this isn't
an API change. The generator reads each subschema's own required list (not the
inherited `allOf`), and `0.64.1` stopped auto-filling fixed values, so the
re-declared `action` now generates as nullable. Adding it to `required` keeps
it non-nullable. CI doesn't actually fail without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
