ebyhr commented on code in PR #16993:
URL: https://github.com/apache/iceberg/pull/16993#discussion_r3488633715


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3093,6 +3093,7 @@ components:
       allOf:
         - $ref: '#/components/schemas/BaseUpdate'
       required:
+        - action

Review Comment:
   In my understanding, `BaseUpdate` already declared required: `action` so 
action was always required by the parent schema. The subschemas 
(`AssignUUIDUpdate` etc.) just forgot to re-declare it in their own required: 
list, even though `allOf: [$ref: BaseUpdate]` already implies it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to