shangxinli commented on PR #776: URL: https://github.com/apache/iceberg-cpp/pull/776#issuecomment-4801979457
Thanks @manuzhang and @zhjwpku for the review. Pushed two follow-up commits addressing all four points: **@manuzhang** - **meson.build** — added `replace_partitions.h` to `src/iceberg/update/meson.build` (commit c2a4a5f). - **Unpartitioned = table-wide replace** (line 61) — `AddFile()` now takes the `DeleteByRowFilter(AlwaysTrue())` path when the spec is unpartitioned, and `Validate()` runs the conflict checks against `AlwaysTrue` in that mode, matching Java `BaseReplacePartitions` (commit 90ae61d). - **`validateDeletedDataFiles`** (line 106) — `Validate()` now calls `ValidateDeletedDataFiles` alongside `ValidateNoNewDeleteFiles` when `ValidateNoConflictingDeletes()` is set, gated on the same flag Java's `validateNewDeletes` controls (commit 90ae61d). - **Reject no-data-files replace** (line 100) — `Validate()` now calls `DataSpec()` up front, which returns `InvalidArgument` if no file was added — same guard Java's `dataSpec()` provides (commit c2a4a5f). **@zhjwpku** - **Hive-compat note** (header line 37) — added the Java-style `\note` recommending `OverwriteFiles` for non-Hive callers (commit c2a4a5f). - **PR description** — updated "extending `SnapshotUpdate`" → "extending `MergingSnapshotUpdate`". PTAL when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
