prafulla-kiran commented on PR #1269: URL: https://github.com/apache/iceberg-go/pull/1269#issuecomment-4798776138
Apologies — I missed your two other inline notes on the first pass (only addressed the test-shape critique). Just force-pushed a second amend covering all three: - **`glue.go:703`** — added the one-line consistency comment. - **`glue_test.go:260`** — moved `assert := require.New(t)` inside the `t.Run` closure so failures bind to the subtest's `t` instead of the parent. Verified by reverting the production change: both `lowercase` and `mixed_case` now fail with correct per-subtest attribution, where previously the parent `FailNow()` killed `mixed_case` before it ran. - **`glue_test.go`** — added `empty` (`table_type=""`) and `absent` (key not in Parameters map) sub-cases, both expecting `is not an iceberg table`. Needed an `omitType bool` on the case struct to build the Parameters map conditionally for the absent case. Full `./catalog/glue/` suite green, lint clean. Sorry for the back-and-forth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
