prafulla-kiran opened a new pull request, #1269: URL: https://github.com/apache/iceberg-go/pull/1269
Fixes #1267 (related: #479, regressed by #537). ### Summary `convertGlueToIceberg` is the only remaining case-sensitive `table_type` check in `catalog/glue/glue.go` — the other two sites (`getTable`, `filterTableListByType`) already use `strings.EqualFold` since #480. This brings the third site in line so `LoadTable` accepts Glue tables written by PyIceberg or via the AWS Glue Iceberg REST endpoint (both emit lowercase `iceberg`), matching the case-insensitive semantics of the PyIceberg and Java Glue implementations. ### Why `LoadTable` → `getTable` now passes case-insensitively but the subsequent `convertGlueToIceberg` rejects the same table, reproducing the symptom from #479 (`table X.Y is not an iceberg table` on a valid Iceberg table). Originally flagged by @tommika in a comment on #479. ### Change - One-line fix at `catalog/glue/glue.go:703`: `!=` → `!strings.EqualFold(...)`. - New unit test `TestGlueConvertGlueToIcebergCaseInsensitive` mirroring the existing `TestGlueGetTableCaseInsensitive`, covering `ICEBERG`, `iceberg`, `IcEbErG`, and a non-Iceberg negative case. Verified by reverting the fix and confirming the new test fails. ### Test plan - [x] `go test ./catalog/glue/` passes - [x] `golangci-lint run ./catalog/glue/...` clean - [x] New test fails without the fix, passes with it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
