twuebi commented on code in PR #1296:
URL: https://github.com/apache/iceberg-go/pull/1296#discussion_r3467887134
##########
table/compaction/compaction.go:
##########
@@ -51,6 +52,14 @@ type Config struct {
// Default: 5.
DeleteFileThreshold int
+ // DeleteRatioThreshold forces a data file into compaction when the
fraction
+ // of its rows shadowed by a deletion vector reaches this value,
regardless
+ // of file size. Deletion vectors are 1:1 with their data file and
carry an
+ // exact deleted-row count, so size-based selection alone never
reclaims a
+ // right-sized file's DV dead space; this rule does. Range [0,1]; 0
disables
+ // it. Default: DefaultDeleteRatioThreshold.
+ DeleteRatioThreshold float64
Review Comment:
broadened to "file-scoped deletes"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
