twuebi commented on code in PR #1296:
URL: https://github.com/apache/iceberg-go/pull/1296#discussion_r3467836624
##########
table/compaction/compaction.go:
##########
@@ -259,13 +276,32 @@ func (cfg Config) PlanCompaction(tasks
[]table.FileScanTask) (Plan, error) {
// isCandidate returns true if a file should be considered for compaction.
func (cfg Config) isCandidate(t table.FileScanTask) bool {
size := t.File.FileSizeBytes()
- deleteCount := len(t.DeleteFiles) + len(t.EqualityDeleteFiles)
+ deleteCount := len(t.DeleteFiles) + len(t.EqualityDeleteFiles) +
len(t.DeletionVectorFiles)
Review Comment:
went for parity with java, which as far as i understand unifies deletes, so
a single dv may trip the count rule, but at default 5 it wouldn't. happy to go
the other way if you prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
