HuaHuaY commented on code in PR #770:
URL: https://github.com/apache/iceberg-cpp/pull/770#discussion_r3465717582
##########
src/iceberg/update/expire_snapshots.h:
##########
@@ -122,6 +122,12 @@ class ICEBERG_EXPORT ExpireSnapshots : public
PendingUpdate {
/// \return Reference to this for method chaining.
ExpireSnapshots& DeleteWith(std::function<void(const std::string&)>
delete_func);
+ /// \brief Configure an executor for planning expired snapshot metadata.
+ ///
+ /// \param executor Executor to use while planning expired snapshot metadata.
+ /// \return Reference to this for method chaining.
+ ExpireSnapshots& PlanWith(Executor& executor);
Review Comment:
I removed the comment from ExecuteDeleteWith. The existence of the executor
is self-evident, guaranteed by the caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
