laskoviymishka opened a new issue, #1273:
URL: https://github.com/apache/iceberg-go/issues/1273

   Follow-up to #963.
   
   #963 deliberately dropped the standalone existence check and let `ReadDir` 
map `fs.ErrNotExist` to `ErrNoSuchNamespace`. The #1185 interface-minimization 
refactor re-introduced a `Stat` before `WalkDir` in `DropNamespace` — but 
`WalkDir` already propagates `fs.ErrNotExist` and the handler already converts 
it, so the leading `Stat` is redundant and only widens the check-to-use window 
where a concurrent caller can delete or recreate the directory between the two 
calls.
   
   Drop the standalone `Stat` and rely on `WalkDir`'s error handling; if the 
not-a-directory case needs preserving, fold it into the `WalkDir` callback on 
the root entry rather than a separate pre-check.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to