laskoviymishka opened a new issue, #1274: URL: https://github.com/apache/iceberg-go/issues/1274
Follow-up to #735. `WriteManifest` still carries its pre-#735 signature and returns only `(ManifestFile, error)` — it forwards no writer or file options, so `ToManifestFile` never sets `FirstRowIDValue` and the returned `ManifestFile.FirstRowID()` is always nil. The real v3 path (`NewManifestListWriterV3` plus the inheritance logic) handles `first_row_id`, but it's reached through `WriteManifestList`, bypassing `WriteManifest` entirely. `WriteManifest` has no production callers — it's a public helper for library consumers, who currently can neither set nor observe `first_row_id` through it, and there's no `WriteManifestV3`. Either add a `WriteManifestV3` helper that takes a `firstRowID` and returns the assigned value alongside the `ManifestFile`, or add a `WithManifestFileFirstRowID` option and forward variadic opts through `WriteManifest`. Keep `WriteManifest` back-compatible. This one touches public API, so it's worth a quick maintainer nod on the shape before someone runs with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
