thswlsqls opened a new pull request, #16872: URL: https://github.com/apache/iceberg/pull/16872
<!-- No issue: minor bug fix, issue not required --> ## Summary - `Expressions.predicate(Operation, String, Literal)` rejects the unary operations IS_NULL, NOT_NULL, IS_NAN, NOT_NAN (which take no value) with the message `Cannot create %s predicate inclusive a value`. - `inclusive a value` is not grammatical and does not describe the failure. - The sibling method `predicate(Operation, String)` rejects value-taking operations with `Cannot create %s predicate without a value`. This is the mirror case — a value passed to a unary op — so the message should read `with a value`. - Fix: change the literal to `Cannot create %s predicate with a value`. No signature, branch, or ABI change. ## Testing done - Added `TestExpressionHelpers#testPredicateWithValueForUnaryOperation` asserting `predicate(IS_NULL, "x", 5)` throws `IllegalArgumentException` with message `Cannot create IS_NULL predicate with a value`. - `./gradlew :iceberg-api:check` — passed (TestExpressionHelpers: 14 tests, 0 failures; includes spotlessCheck, checkstyle, errorProne). - `./gradlew :iceberg-api:revapi` — passed (backward compatible; only an error-message string changed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
