CTTY commented on code in PR #16853:
URL: https://github.com/apache/iceberg/pull/16853#discussion_r3439012179
##########
aws/src/test/java/org/apache/iceberg/aws/glue/TestIcebergToGlueConverter.java:
##########
@@ -384,4 +384,57 @@ public void
testSetTableInputInformationWithExistingTable() {
.as("Columns should match")
.isEqualTo(expectedTableInput.storageDescriptor().columns());
}
+
+ @Test
+ public void
testSetTableInputInformationWithDuplicateExistingColumnComments() {
Review Comment:
nit: How about just `testDuplicateExistingColumnsKeepFirstComment`
##########
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##########
@@ -266,10 +266,14 @@ static void setTableInputInformation(
Map<String, String> existingColumnMap = null;
Review Comment:
nit: I think we should rename this map to `columnNameToComment` or
`existingColumnNameToComment`, same goes for the naming of this map in
`toColumns` and `addColumnWithDedupe`. The current name is confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
