ebyhr commented on code in PR #16853:
URL: https://github.com/apache/iceberg/pull/16853#discussion_r3432117679
##########
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java:
##########
@@ -269,7 +269,9 @@ static void setTableInputInformation(
existingColumnMap =
existingColumns.stream()
.filter(column -> column.comment() != null)
- .collect(Collectors.toMap(Column::name, Column::comment));
+ .collect(
+ Collectors.toMap(
+ Column::name, Column::comment, (existing, duplicate)
-> existing));
Review Comment:
How about leaving a code comment explaining why `existing` should win? For
me, it's unclear when reading this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
