amogh-jahagirdar commented on code in PR #16823:
URL: https://github.com/apache/iceberg/pull/16823#discussion_r3433023719
##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -456,10 +456,11 @@ void testManifestDVPositionsProduceModified() {
Tracking addedSource = manifestSourceTracking();
Tracking modified =
TrackingBuilder.from(addedSource,
999L).deletedPositions(deletedBytes).build();
+
assertThat(modified.status()).isEqualTo(EntryStatus.MODIFIED);
- // the entry snapshot id is preserved; only the DV snapshot id advances to
the commit snapshot
+ // the entry snapshot id is preserved; dv snapshot id is not relevant for
manifest entries
Review Comment:
DV snapshot ID must not be set?
##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -456,10 +456,11 @@ void testManifestDVPositionsProduceModified() {
Tracking addedSource = manifestSourceTracking();
Tracking modified =
TrackingBuilder.from(addedSource,
999L).deletedPositions(deletedBytes).build();
+
Review Comment:
Nit: Can we remove the newline, we can avoid conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
