stevenzwu commented on PR #16823: URL: https://github.com/apache/iceberg/pull/16823#issuecomment-4734868519
yeah. I was at the Monday sync when Amogh brought up this question. Amogh's point was that `deletedPositions` and `replacedPositions` should only be set for the snapshot when the change was made. In the next snapshot, they should be reset to null if there is no new change. With that strict reset behavior, dvSnapshotId doesn't necessarily need to advance, as change detection won't rely on the check of dvSnapshotId vs currentSnapshotId. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
