wgtmac commented on code in PR #753: URL: https://github.com/apache/iceberg-cpp/pull/753#discussion_r3432546637
########## cmake_modules/IcebergThirdpartyToolchain.cmake: ########## @@ -742,3 +742,14 @@ endif() if(ICEBERG_BUILD_SQL_CATALOG) resolve_sql_catalog_dependencies() endif() + +# Arrow's bundled build creates the Thrift C++ runtime as a `thrift` target Review Comment: I'd recommend to follow `resolve_aws_sdk_dependency` and `ICEBERG_AWSSDK_BUNDLED` to either bundle or use system thrift. ########## cmake_modules/IcebergThirdpartyToolchain.cmake: ########## @@ -742,3 +742,14 @@ endif() if(ICEBERG_BUILD_SQL_CATALOG) resolve_sql_catalog_dependencies() endif() + +# Arrow's bundled build creates the Thrift C++ runtime as a `thrift` target Review Comment: I'd recommend follow `resolve_aws_sdk_dependency` and `ICEBERG_AWSSDK_BUNDLED` to either bundle or use system thrift. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
