nastra commented on code in PR #16736:
URL: https://github.com/apache/iceberg/pull/16736#discussion_r3429221333
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopConfigurable.java:
##########
@@ -31,7 +30,7 @@
* object to implement this interface so that a serializable supplier of
configuration can be
* provided instead of an actual Hadoop configuration which is not
serializable.
*/
-public interface HadoopConfigurable extends Configurable {
+public interface HadoopConfigurable extends Configurable<Configuration> {
Review Comment:
I'm fine with this change but we might eventually want to change this to
`HadoopConfigurable extends Configurable<Object>` so that this is really only
loaded in environments that actually have Hadoop on the classpath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
