adutra commented on code in PR #16822:
URL: https://github.com/apache/iceberg/pull/16822#discussion_r3419749776
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5247,6 +5255,43 @@ components:
headers:
$ref: '#/components/schemas/MultiValuedMap'
+ RemoteSigningConfig:
+ description: |
+ Configuration for the remote signer client.
+ When present, clients MUST use this structure instead of the
deprecated `signer.uri` and
+ `signer.endpoint` properties in the `config` map.
+ type: object
+ required:
+ - base-uri
+ - endpoint-path
+ properties:
+ base-uri:
+ type: string
+ description: >
+ The base URI of the signing service as perceived by the client,
incorporating X-Forwarded-*
+ headers set by proxies. When present, takes precedence over the
deprecated `signer.uri`
+ config property.
+ endpoint-path:
Review Comment:
Open question to reviewers:
Should we **require** the endpoint path to match the canonical endpoint path
exposed in this spec, that is,
`/v1/{prefix}/namespaces/{namespace}/tables/{table}/sign`?
If so, `endpoint-path` becomes redundant / optional, because clients could
recompose the full URI by just appending the canonical path to `base-uri`.
Example: if `base-uri` is `https://catalog.example.com/api/iceberg`, then
the client can infer the full URI since it already knows the prefix, namespace
and table:
```
https://catalog.example.com/api/iceberg/v1/warehouse1/namespaces/ns1/tables/table1/sign
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
