sungwy commented on code in PR #16822:
URL: https://github.com/apache/iceberg/pull/16822#discussion_r3421497449
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5247,6 +5255,43 @@ components:
headers:
$ref: '#/components/schemas/MultiValuedMap'
+ RemoteSigningConfig:
+ description: |
+ Configuration for the remote signer client.
+ When present, clients MUST use this structure instead of the
deprecated `signer.uri` and
+ `signer.endpoint` properties in the `config` map.
+ type: object
+ required:
+ - base-uri
+ - endpoint-path
+ properties:
+ base-uri:
+ type: string
+ description: >
+ The base URI of the signing service as perceived by the client,
incorporating X-Forwarded-*
+ headers set by proxies. When present, takes precedence over the
deprecated `signer.uri`
+ config property.
+ endpoint-path:
Review Comment:
I'd lean toward just having the server send the explicit signing path rather
than making `endpoint-path` optional and inferring it client-side. Inferring
the fully qualified path is an implicit contract... if the canonical path ever
changes, we'd have to coordinate that across every client.
I think it's simpler and easier to evolve if we keep it explicit. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
