smaheshwar-pltr commented on code in PR #16796:
URL: https://github.com/apache/iceberg/pull/16796#discussion_r3407389741
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1800,12 +1800,16 @@ private static List<MetadataLogEntry> addPreviousFile(
int maxSize =
Math.max(
- 1,
+ 0,
Review Comment:
Pointing out that a negative value for this property now corresponds to an
empty log - previously, it was a log of maximum size one. This is technically a
*break*, but that felt fine to me
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1800,12 +1800,16 @@ private static List<MetadataLogEntry> addPreviousFile(
int maxSize =
Math.max(
- 1,
+ 0,
Review Comment:
Pointing out that a negative value for this property now corresponds to an
empty log - previously, it was a log of maximum size one. This is technically a
*break*, but it felt fine to me. Curious for thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
