Kurtiscwright opened a new pull request, #2633: URL: https://github.com/apache/iceberg-rust/pull/2633
This PR was written with help from LLM based tools. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> Add a `CatalogType` enum to the catalog loader that lets callers select a built-in catalog by a declared variant (`CatalogType::Rest`) instead of a bare type string, with an inherent `async fn load` that dispatches via an exhaustive match. Including `Memory` closes a gap where the in-memory catalog was absent from the string registry. This is purely additive: the existing free `load(&str)`, `supported_types()`, `CatalogLoader`, and `BoxedCatalogBuilder` are left unchanged and continue to work alongside the new selector. This approach will be repeated for how file format's registry will be implemented. Applying the approach here is aimed at improving the Catalog selection to be more idiomatic and to get alignment from the community on how we want to structure registries. ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Brand new unit tests to validate that storage factory is passed through correctly as well as overall functionality is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
