fallintoplace opened a new pull request, #1198: URL: https://github.com/apache/iceberg-go/pull/1198
Summary - make `truncate[string]` truncate at UTF-8 rune boundaries instead of byte offsets - keep `truncate[binary]` byte-based - add regression coverage for Apply, Transformer, and Project paths Why `TruncateTransform.Transformer` handled strings and binary values with the same byte-slicing branch. For non-ASCII strings, a width could split a UTF-8 code point and produce an invalid string partition value. Testing - `go test . -run "TestTruncateStringDoesNotSplitUTF8|TestTruncateTransform|TestCanTransform|TestManifestPartitionVals" -count=1` - `go test ./... -count=1` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
