xanderbailey commented on code in PR #2628: URL: https://github.com/apache/iceberg-rust/pull/2628#discussion_r3404458691
########## crates/iceberg/src/spec/manifest/writer.rs: ########## Review Comment: I didn't realise this at the time but it's likely incorrect that we have `key_metadata` in this constructor at all. This should never be present with a plaintext `OutputFile`. But in https://github.com/apache/iceberg-rust/pull/2568 we discussed a desire to not break this API but on closer look, I think the current API here is error-prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
