xanderbailey commented on code in PR #2628:
URL: https://github.com/apache/iceberg-rust/pull/2628#discussion_r3404443406


##########
crates/iceberg/public-api.txt:
##########
@@ -2079,7 +2079,7 @@ pub fn 
iceberg::spec::ManifestWriterBuilder::build_v2_deletes(self) -> iceberg::
 pub fn iceberg::spec::ManifestWriterBuilder::build_v3_data(self) -> 
iceberg::spec::ManifestWriter
 pub fn iceberg::spec::ManifestWriterBuilder::build_v3_deletes(self) -> 
iceberg::spec::ManifestWriter
 pub fn iceberg::spec::ManifestWriterBuilder::new(output: 
iceberg::io::OutputFile, snapshot_id: core::option::Option<i64>, key_metadata: 
core::option::Option<alloc::vec::Vec<u8>>, schema: iceberg::spec::SchemaRef, 
partition_spec: iceberg::spec::PartitionSpec) -> Self
-pub fn 
iceberg::spec::ManifestWriterBuilder::new_from_encrypted(encrypted_output: 
iceberg::encryption::EncryptedOutputFile, snapshot_id: 
core::option::Option<i64>, key_metadata: 
core::option::Option<alloc::vec::Vec<u8>>, schema: iceberg::spec::SchemaRef, 
partition_spec: iceberg::spec::PartitionSpec) -> Self
+pub fn 
iceberg::spec::ManifestWriterBuilder::new_from_encrypted(encrypted_output: 
iceberg::encryption::EncryptedOutputFile, snapshot_id: 
core::option::Option<i64>, schema: iceberg::spec::SchemaRef, partition_spec: 
iceberg::spec::PartitionSpec) -> iceberg::Result<Self>

Review Comment:
   This isn't a break to users since this hasn't been released or used within 
the crate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to