Guosmilesmile commented on code in PR #16724:
URL: https://github.com/apache/iceberg/pull/16724#discussion_r3395797443
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -185,11 +191,16 @@ private static List<Record> project(List<Record> records,
Schema targetSchema) {
FEATURE_CASE_SENSITIVE,
FEATURE_SPLIT,
FEATURE_COLUMN_LEVEL_METRICS,
- FEATURE_COLUMN_METRICS_TRUNCATE_BINARY
+ FEATURE_COLUMN_METRICS_TRUNCATE_BINARY,
+ FEATURE_ENCRYPTION
},
FileFormat.ORC,
new String[] {
- FEATURE_REUSE_CONTAINERS, FEATURE_COLUMN_METRICS_TRUNCATE_BINARY,
FEATURE_READER_DEFAULT
+ FEATURE_REUSE_CONTAINERS,
+ FEATURE_COLUMN_METRICS_TRUNCATE_BINARY,
+ FEATURE_READER_DEFAULT,
+ FEATURE_ENCRYPTION_KEY_METADATA,
+ FEATURE_ENCRYPTION
});
Review Comment:
So it seems to me that the underlying implementation still relies on
`keyMetadata` rather than calling those other two methods. I want to verify
whether these two methods actually take effect—is there a better way to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
