Guosmilesmile commented on code in PR #16724:
URL: https://github.com/apache/iceberg/pull/16724#discussion_r3395398530
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -185,11 +191,16 @@ private static List<Record> project(List<Record> records,
Schema targetSchema) {
FEATURE_CASE_SENSITIVE,
FEATURE_SPLIT,
FEATURE_COLUMN_LEVEL_METRICS,
- FEATURE_COLUMN_METRICS_TRUNCATE_BINARY
+ FEATURE_COLUMN_METRICS_TRUNCATE_BINARY,
+ FEATURE_ENCRYPTION
},
FileFormat.ORC,
new String[] {
- FEATURE_REUSE_CONTAINERS, FEATURE_COLUMN_METRICS_TRUNCATE_BINARY,
FEATURE_READER_DEFAULT
+ FEATURE_REUSE_CONTAINERS,
+ FEATURE_COLUMN_METRICS_TRUNCATE_BINARY,
+ FEATURE_READER_DEFAULT,
+ FEATURE_ENCRYPTION_KEY_METADATA,
+ FEATURE_ENCRYPTION
});
Review Comment:
When I only call keyMetadata in Parquet, reading the file fails if I don't
go through EncryptingFileIO.This appears to be encrypted. Is there something
wrong with this?
https://github.com/Guosmilesmile/iceberg/blob/5c5989477de88a252840f8b7275132e258047240/data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java#L1722-L1735
`
Trying to read file with encrypted footer. No keys available
org.apache.parquet.crypto.ParquetCryptoRuntimeException: Trying to read file
with encrypted footer. No keys available
at
org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:655)
at
org.apache.parquet.hadoop.ParquetFileReader.readFooter(ParquetFileReader.java:578)
at
org.apache.parquet.hadoop.ParquetFileReader.<init>(ParquetFileReader.java:971)
at
org.apache.parquet.hadoop.ParquetFileReader.<init>(ParquetFileReader.java:961)
at
org.apache.parquet.hadoop.ParquetFileReader.open(ParquetFileReader.java:730)
at org.apache.iceberg.parquet.ReadConf.newReader(ReadConf.java:194)
at org.apache.iceberg.parquet.ReadConf.<init>(ReadConf.java:76)
at
org.apache.iceberg.parquet.ParquetReader.init(ParquetReader.java:74)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
