plusplusjiajia commented on code in PR #616: URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3395048991
########## src/iceberg/catalog/rest/rest_catalog.cc: ########## @@ -479,6 +523,7 @@ Result<std::shared_ptr<Table>> RestCatalog::LoadTable(const TableIdentifier& ide ICEBERG_ASSIGN_OR_RAISE(const auto body, LoadTableInternal(identifier)); ICEBERG_ASSIGN_OR_RAISE(auto json, FromJsonString(body)); ICEBERG_ASSIGN_OR_RAISE(auto load_result, LoadTableResultFromJson(json)); + ICEBERG_RETURN_UNEXPECTED(RememberTableSession(identifier, load_result.config)); Review Comment: @wgtmac Done in the latest push — `LoadTableInternal()` now sends with `SessionFor(identifier)` (cached table session for refresh, catalog session for the initial load). Added `RestCatalogSessionTest.RefreshAndCommitUseTableSessionFromResponseConfig`, which runs a minimal in-test HTTP server and asserts refresh and commit carry the session derived from the response `config.token`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
