plusplusjiajia commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3394446144
##########
src/iceberg/catalog/rest/meson.build:
##########
@@ -40,17 +41,27 @@ cpr_needs_static = (
)
cpr_dep = dependency('cpr', static: cpr_needs_static)
+iceberg_rest_sources += files('auth/sigv4_auth_manager.cc')
iceberg_rest_build_deps = [iceberg_dep, cpr_dep]
+iceberg_rest_compile_defs = []
+
+sigv4_opt = get_option('sigv4')
+aws_sdk_core_dep = dependency('aws-cpp-sdk-core', required: sigv4_opt)
Review Comment:
@wgtmac CI does run the Meson SigV4 path: the `meson-sigv4` job in
`aws_test.yml` provisions aws-sdk-cpp via vcpkg and runs `meson setup
-Dsigv4=enabled` + `meson test` (green on this PR). The Meson path resolves a
system-installed SDK only — bundling is a CMake/Arrow mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
