Baunsgaard commented on PR #16740: URL: https://github.com/apache/iceberg/pull/16740#issuecomment-4672416387
> Nice, this is right improvement. `SCALE` write dominates these tests, and caching the golden files per table shape is exactly where the ~8% win should come from. Re-appending the same physical files is spec-legal too, since sequence numbers and `firstRowId` are assigned on each append. > > ... > > Once those are addressed, happy to do one more pass. Thanks for the review @laskoviymishka ! I have addressed all the four blockers! One Nit: I left the DCL-vs-`PER_METHOD` and virtual-dispatch nits as-is for now. I know my implementation on the locking is hypothetical for future parallel execution and the tests are run single threaded now, but i thought it would be fine to make it thread-safe already now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
