Baunsgaard commented on code in PR #16696:
URL: https://github.com/apache/iceberg/pull/16696#discussion_r3387971828
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/RandomData.java:
##########
@@ -52,6 +52,11 @@ public class RandomData {
// Default percentage of number of values that are null for optional fields
public static final float DEFAULT_NULL_PERCENTAGE = 0.05f;
+ // Exclusive upper bound on the number of elements generated for each
list/map.
+ // Applied per nesting level, so deeply-nested schemas multiply quickly; keep
+ // this small enough to avoid combinatorial blow-up in heavily-nested tests.
+ private static final int MAX_COLLECTION_SIZE = 10;
Review Comment:
We can change it to `_BOUND` this makes sense to me.
However, explicitly saying max 9, is a bit too much IMO, since the comment
starts with `Exclusive upper bound` which exactly means what we intend to
communicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
