paleolimbot commented on code in PR #1138:
URL: https://github.com/apache/iceberg-go/pull/1138#discussion_r3382639516
##########
table/arrow_utils.go:
##########
@@ -1828,3 +1844,72 @@ func positionDeleteRecordsToDataFilesDV(ctx
context.Context, rootLocation string
}
}
}
+
+func geoArrowCRSToIcebergCRS(meta geoarrow.Metadata) (string, error) {
+ if len(meta.CRS) == 0 && meta.CRSType == "" {
+ return "srid:0", nil
Review Comment:
> bare ga.wkb() field with no CRS — the PyIceberg default and what older
clients emit — reads back as geometry("srid:0") rather than geometry(), which
isn't Equals to a default-CRS geometry.
This is the correct behaviour: the GeoArrow default does not equal the
Iceberg default. PyIceberg is probably wrong here.
> Separately, an empty meta.CRS with a non-empty CRSType skips this early
return
This should be fixed...the CRSType can actually just be ignored for the
purposes of this function (it's purely a hint)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
