ahshahid commented on code in PR #16570:
URL: https://github.com/apache/iceberg/pull/16570#discussion_r3337360274
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkRuntimeFilterableScan.java:
##########
@@ -195,6 +195,6 @@ private Expression convertRuntimePredicates(Predicate[]
predicates) {
}
protected String runtimeFiltersDesc() {
- return Spark3Util.describe(runtimeFilters);
+ return createOrderedExprString(runtimeFilters.stream());
Review Comment:
I suppose so , for the top level "and " operands.. The subtree in any case
will remain unchanged ( except for sorted ordering).
Do you want to separate out the behaviour for explain from equals/hashCode?
Coz ,as you already know, (a =1 and b =2 ), c = 3 is same as a =1, b =2, c
= 3. and I would assume, that the latter is in any case cleaner...but up to you
.. I am ok with either way and can accordingly make change...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
