ahshahid commented on PR #16570: URL: https://github.com/apache/iceberg/pull/16570#issuecomment-4664865623
"Let's keep them separate. Normalization (flatten + sort) is only needed for the equals/hashCode contract that enables exchange reuse — that's the scope of this bug. Changing the user-facing EXPLAIN output (flattening top-level ANDs + reordering) is a separate behavior change I'd rather not bundle into a bugfix, since downstream tooling / golden-file tests may parse the plan. So: keep filtersDesc() / runtimeFiltersDesc() (used by description()) as Spark3Util.describe(...), add a separate canonical method used only by equals/hashCode. Making EXPLAIN deterministic can be a follow-up if we decide we want it." Ok.. will do that. though pls note that while debugging, using the printed plan , one may get impression that the issue may be because of mismatch of Scans due to unordered filters...( which ofcourse after the bug fix will not be a valid conclusion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
