rdblue commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3337126909
##########
core/src/test/java/org/apache/iceberg/TestManifestInfoStruct.java:
##########
@@ -23,26 +23,57 @@
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.util.List;
+import java.util.Map;
+import java.util.function.Consumer;
+import java.util.stream.Stream;
import org.apache.iceberg.types.Types;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
class TestManifestInfoStruct {
+ // Ordinals looked up from ManifestInfo.schema() so tests don't hard-code
positions.
+ private static final List<Types.NestedField> INFO_FIELDS =
ManifestInfo.schema().fields();
+ private static final int ADDED_FILES_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.ADDED_FILES_COUNT);
+ private static final int EXISTING_FILES_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.EXISTING_FILES_COUNT);
+ private static final int DELETED_FILES_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.DELETED_FILES_COUNT);
+ private static final int REPLACED_FILES_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.REPLACED_FILES_COUNT);
+ private static final int ADDED_ROWS_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.ADDED_ROWS_COUNT);
+ private static final int EXISTING_ROWS_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.EXISTING_ROWS_COUNT);
+ private static final int DELETED_ROWS_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.DELETED_ROWS_COUNT);
+ private static final int REPLACED_ROWS_COUNT_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.REPLACED_ROWS_COUNT);
+ private static final int MIN_SEQUENCE_NUMBER_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.MIN_SEQUENCE_NUMBER);
+ private static final int DV_ORDINAL = INFO_FIELDS.indexOf(ManifestInfo.DV);
+ private static final int DV_CARDINALITY_ORDINAL =
+ INFO_FIELDS.indexOf(ManifestInfo.DV_CARDINALITY);
+
@Test
void testFieldAccess() {
ManifestInfoStruct info = new ManifestInfoStruct(ManifestInfo.schema());
- info.set(0, 10);
- info.set(1, 20);
- info.set(2, 3);
- info.set(3, 2);
- info.set(4, 1000L);
- info.set(5, 2000L);
- info.set(6, 300L);
- info.set(7, 200L);
- info.set(8, 5L);
- info.set(9, ByteBuffer.wrap(new byte[] {0xF}));
- info.set(10, 1L);
+ info.set(ADDED_FILES_COUNT_ORDINAL, 10);
+ info.set(EXISTING_FILES_COUNT_ORDINAL, 20);
+ info.set(DELETED_FILES_COUNT_ORDINAL, 3);
+ info.set(REPLACED_FILES_COUNT_ORDINAL, 2);
+ info.set(ADDED_ROWS_COUNT_ORDINAL, 1000L);
+ info.set(EXISTING_ROWS_COUNT_ORDINAL, 2000L);
+ info.set(DELETED_ROWS_COUNT_ORDINAL, 300L);
+ info.set(REPLACED_ROWS_COUNT_ORDINAL, 200L);
+ info.set(MIN_SEQUENCE_NUMBER_ORDINAL, 5L);
+ info.set(DV_ORDINAL, ByteBuffer.wrap(new byte[] {0xF}));
+ info.set(DV_CARDINALITY_ORDINAL, 1L);
Review Comment:
Wait, why doesn't this just call the constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
