rdblue commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3336937905
##########
core/src/main/java/org/apache/iceberg/Tracking.java:
##########
@@ -115,4 +115,10 @@ default boolean isLive() {
/** Copies this tracking information. */
Tracking copy();
+
+ /** Returns a DELETED tracking row derived from this one in the given
snapshot. */
+ Tracking asDeleted(long currentSnapshotId);
Review Comment:
Should this be `newSnapshotId`? I wonder if "current" is clear enough.
Also, I don't think that we had a reason to have this here vs in the builder
when we talked, but seeing this in the public API makes me wonder if callers
are ever going to need these or the builder. I think `Tracking` will always be
initialized and supplied by the library, so maybe we don't need this to ever be
exposed publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
