RussellSpitzer commented on code in PR #16577:
URL: https://github.com/apache/iceberg/pull/16577#discussion_r3313731781
##########
format/spec.md:
##########
@@ -1502,7 +1502,7 @@ Maps with non-string keys must use an array
representation with the `map` logica
Notes:
-1. Avro type annotation `adjust-to-utc` is an Iceberg convention; default
value is `false` if not present.
+1. Non-zone timestamp types are written using Avro's
`local-timestamp-{micros,nanos}` logical types. Zone-adjusted timestamp types
are written using `timestamp-{micros,nanos}` with `adjust-to-utc: true`.
Readers must also accept legacy files that encode non-zone timestamps as
`timestamp-{micros,nanos}` with `adjust-to-utc: false`.
Review Comment:
Let's back this out into a separate PR and do it first. We just had a lot of
discussion on a similar issue for "dates" transform and I think we should have
a discussion on this to make sure we aren't doing something that will break
other implementations.
I would recommend starting a thread on the dev list and point to a specific
PR for this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
