Shekharrajak commented on code in PR #16577:
URL: https://github.com/apache/iceberg/pull/16577#discussion_r3309564964
##########
core/src/main/java/org/apache/iceberg/avro/InternalReader.java:
##########
@@ -178,13 +178,14 @@ public ValueReader<?> primitive(Pair<Integer, Type>
partner, Schema primitive) {
return ValueReaders.longs();
case "timestamp-millis":
- // adjust to microseconds
+ case "local-timestamp-millis":
ValueReader<Long> longs = ValueReaders.longs();
return (ValueReader<Long>) (decoder, ignored) ->
longs.read(decoder, null) * 1000L;
case "timestamp-micros":
case "timestamp-nanos":
- // both are handled in memory as long values, using the type to
track units
+ case "local-timestamp-micros":
Review Comment:
decode as long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
