wombatu-kun commented on code in PR #16498:
URL: https://github.com/apache/iceberg/pull/16498#discussion_r3292019236
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -1025,6 +1025,64 @@ public void testCompareToFileList() throws IOException {
assertThat(result4.orphanFilesCount()).as("Action should find
nothing").isEqualTo(0L);
}
+ @TestTemplate
+ public void testCompareToFileListWithSiblingDirectory() throws IOException {
Review Comment:
Good idea — I folded the exact-match case into the same scope test (renamed
to `testCompareToFileListExcludesPathsOutsideLocationScope`, applied across
v3.5/v4.0/v4.1). Alongside the sibling directory it now adds a
`compareToFileList` entry whose path equals `location` exactly and asserts it
isn't reported as orphan, documenting that the trailing-separator prefix
excludes exact matches as deliberate behavior. Done in 341d03877.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
