sungwy commented on code in PR #16498:
URL: https://github.com/apache/iceberg/pull/16498#discussion_r3291832220
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -1025,6 +1025,64 @@ public void testCompareToFileList() throws IOException {
assertThat(result4.orphanFilesCount()).as("Action should find
nothing").isEqualTo(0L);
}
+ @TestTemplate
+ public void testCompareToFileListWithSiblingDirectory() throws IOException {
Review Comment:
nit: in addition to checking the sibling location, could we include a case
where `file_path == location`? Since the new filtering behavior excludes exact
match, I think it would be helpful to add a test to call out the behavior
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
