fallintoplace opened a new pull request, #1110: URL: https://github.com/apache/iceberg-go/pull/1110
## Summary - reject invalid `bucket[...]` and `truncate[...]` widths during `ParseTransform` - treat `Atoi` errors, zero widths, and values above `math.MaxInt32` as invalid transforms - add parse regression coverage for zero, huge overflow, and int32-overflow widths ## Why `ParseTransform` previously ignored the `strconv.Atoi` error and accepted zero widths. Those invalid transforms could later panic when bucket/truncate logic performed modulo by the width. Values larger than `math.MaxInt32` are also unsafe because bucket/truncate implementations narrow widths through int32-sized paths. Fixes #1109. ## Testing - `go test . -run TestParseTransform` - `go test .` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
