c-thiel commented on code in PR #12584:
URL: https://github.com/apache/iceberg/pull/12584#discussion_r3275757167
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3545,6 +3652,69 @@ components:
allOf:
- $ref: '#/components/schemas/ScanTasks'
+ QueryEventsRequest:
+ type: object
+ properties:
+ continuation-token:
+ type: string
+ description: >
+ A continuation token to resume fetching events from a previous
request.
+ If not provided, events are fetched from the beginning of the
event log
+ subject to other filters.
+ page-size:
+ type: integer
+ format: int32
+ description: >
+ The maximum number of events to return in a single response.
+ If not provided, the server may choose a default page size.
+ Servers may return less results than requested for various
reasons, such as
+ server side limits, payload size or processing time.
+ after-timestamp-ms:
Review Comment:
Event logs can become quite long - we need to be able to start paginating
from somewhere in-between (typically client provided). Because clients cannot
generate `continuation-token` (its opaque), they need a way to roughly set the
starting timestamp. Otherwise the only option to obtain a recent event would be
to iterate the whole stored history.
I don't think `before-timestamp-ms` is required right now as clients can
just as well stop iterating. Without this filter the worst that can happen is
that servers return a few too many items on the last page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
