hsiang-c commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3263407615


##########
crates/iceberg/src/table.rs:
##########
@@ -33,6 +35,7 @@ pub struct TableBuilder {
     metadata_location: Option<String>,
     metadata: Option<TableMetadataRef>,
     identifier: Option<TableIdent>,
+    kms_client: Option<Arc<dyn KeyManagementClient>>,

Review Comment:
   Sounds good to me, thanks @xanderbailey.
   
   I think it is closer to the `encryption()` method in Java's 
[`HiveTableOperations.java`](https://github.com/apache/iceberg/blob/main/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L141-L167)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to