xanderbailey commented on code in PR #2453:
URL: https://github.com/apache/iceberg-rust/pull/2453#discussion_r3247056121
##########
crates/iceberg/src/table.rs:
##########
@@ -33,6 +35,7 @@ pub struct TableBuilder {
metadata_location: Option<String>,
metadata: Option<TableMetadataRef>,
identifier: Option<TableIdent>,
+ kms_client: Option<Arc<dyn KeyManagementClient>>,
Review Comment:
Thanks for taking a look! In Java's case the kms is configured at the
catalog level (`CatalogProperties.ENCRYPTION_KMS_*`) and I think we should do
the same, the catalog will take some `KmsFactory` and construct the KMS for the
table?
##########
crates/iceberg/src/table.rs:
##########
@@ -33,6 +35,7 @@ pub struct TableBuilder {
metadata_location: Option<String>,
metadata: Option<TableMetadataRef>,
identifier: Option<TableIdent>,
+ kms_client: Option<Arc<dyn KeyManagementClient>>,
Review Comment:
Thanks for taking a look! In Java's case the kms is configured at the
catalog level (`CatalogProperties.ENCRYPTION_KMS_*`) and I think we should do
the same, the catalog will take some `KmsFactory` and construct the KMS for the
table? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
