wgtmac commented on code in PR #646:
URL: https://github.com/apache/iceberg-cpp/pull/646#discussion_r3247389313
##########
src/iceberg/catalog/rest/auth/auth_session.cc:
##########
@@ -52,12 +236,17 @@ std::shared_ptr<AuthSession> AuthSession::MakeDefault(
}
std::shared_ptr<AuthSession> AuthSession::MakeOAuth2(
- const OAuthTokenResponse& initial_token, const std::string&
/*token_endpoint*/,
- const std::string& /*client_id*/, const std::string& /*client_secret*/,
- const std::string& /*scope*/, HttpClient& /*client*/) {
- // TODO(lishuxu): Create OAuth2AuthSession with auto-refresh support.
- return MakeDefault({{std::string(kAuthorizationHeader),
- std::string(kBearerPrefix) +
initial_token.access_token}});
+ const OAuthTokenResponse& initial_token, const std::string& token_endpoint,
+ const std::string& client_id, const std::string& client_secret,
+ const std::string& scope, HttpClient& client) {
+ OAuth2AuthSession::Config config{
+ .token_endpoint = token_endpoint,
+ .client_id = client_id,
+ .client_secret = client_secret,
+ .scope = scope,
+ .keep_refreshed = true,
Review Comment:
Pass the parsed `token-refresh-enabled` value into this config instead of
forcing refresh on. Users who disable refresh should not get background token
requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
